Please, don't block W-A-S-D keys on manga reader
2
Current W-A-S-D patch for manga reader may feel nice for some people, but it has a drawback: The keys are being checked without modifiers, so on some browsers (i.e. Firefox), you can no longer press <C-w> to close tab, because it's been bound to move view.
That can be easily patched:
Within this code...
Change this:
BTW W-A-S-D is boring, a vim-like H-J-K-L would be geekly nicer!
That can be easily patched:
Within this code...
$(document).keydown(function(ev) {
if (!keyHold) {
// left, a
if (ev.keyCode == 37 || ev.keyCode == 65) {
if (!keyHold) {
// left, a
if (ev.keyCode == 37 || ev.keyCode == 65) {
Change this:
$(document).keydown(function(ev) {
if (!keyHold[b] && !ev.ctrlKey && !ev.altKey[/b]) {
// left, a
if (ev.keyCode == 37 || ev.keyCode == 65) {
if (!keyHold[b] && !ev.ctrlKey && !ev.altKey[/b]) {
// left, a
if (ev.keyCode == 37 || ev.keyCode == 65) {
BTW W-A-S-D is boring, a vim-like H-J-K-L would be geekly nicer!
0
warcry wrote...
Current W-A-S-D patch for manga reader may feel nice for some people, but it has a drawback: The keys are being checked without modifiers, so on some browsers (i.e. Firefox), you can no longer press <C-w> to close tab, because it's been bound to move view.That can be easily patched:
Within this code...
$(document).keydown(function(ev) {
if (!keyHold) {
// left, a
if (ev.keyCode == 37 || ev.keyCode == 65) {
if (!keyHold) {
// left, a
if (ev.keyCode == 37 || ev.keyCode == 65) {
Change this:
$(document).keydown(function(ev) {
if (!keyHold[b] && !ev.ctrlKey && !ev.altKey[/b]) {
// left, a
if (ev.keyCode == 37 || ev.keyCode == 65) {
if (!keyHold[b] && !ev.ctrlKey && !ev.altKey[/b]) {
// left, a
if (ev.keyCode == 37 || ev.keyCode == 65) {
BTW W-A-S-D is boring, a vim-like H-J-K-L would be geekly nicer!
Awesome recommendation, I didn't realize that was happening in Firefox (I'm a Chrome user). I added your fix and it should be working now :)
0
Gravity cat
the adequately amused
One can confirm that it works now. (Didn't even notice that it didn't, personally)
Probably didn't need me to but ah well
Probably didn't need me to but ah well
